Author inada.naoki
Recipients inada.naoki, rhettinger, serhiy.storchaka, vstinner, xiang.zhang
Date 2016-10-28.12:01:58
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <1477656118.74.0.516828798585.issue28199@psf.upfronthosting.co.za>
In-reply-to
Content
Current code and my patch called insertdict_clean() or insert_index() for each entry.
On the other hand, Serhiy's patch calls build_indices() once.
This may be faster when compiler doesn't inlining the helper function.
As a bonus, we can use memcpy to copy entries.

Cons of Serhiy's patch is it's two pass. If entries are larger than L2 cache,
fetch from L3 cache may be larger.
So I can't declare that Serhiy's patch is faster until benchmark.

(My forecast is no performance difference between my patch and Serhiy's on amd64
machine, and Serhiy's patch is faster on more poor CPU.)
History
Date User Action Args
2016-10-28 12:01:58inada.naokisetrecipients: + inada.naoki, rhettinger, vstinner, serhiy.storchaka, xiang.zhang
2016-10-28 12:01:58inada.naokisetmessageid: <1477656118.74.0.516828798585.issue28199@psf.upfronthosting.co.za>
2016-10-28 12:01:58inada.naokilinkissue28199 messages
2016-10-28 12:01:58inada.naokicreate