Message279533
New patch taking into account Martin last review and some updated comments.
>> Why do you remove the code that loops over Modules/Setup? Maybe is it redundant with the other code for removing the already-built-in modules?
> Yes because this is redundant, maybe not the case when this was written 15 years ago.
* sys.builtin_module_names are the modules listed in the _PyImport_Inittab[] array that is built by Modules/makesetup from Modules/config.c.in and the '*static*' modules configured in the Setup files (those Setup files that are listed in the rule of the 'Makefile' target of the Makefile). This list is missing the '*shared*' modules configured in the Setup files and that should not be built by setup.py.
* The setup.py code that loops over and loosely parses some of the Modules/Setup files, excludes both '*static*' and '*shared*' modules from the built modules.
* 'MODNAMES' does the same thing in the patch accurately as the list is built by makesetup.
New issue 28542 to document the cross-compilation. |
|
Date |
User |
Action |
Args |
2016-10-27 10:27:11 | xdegaye | set | recipients:
+ xdegaye, akuchling, doko, martin.panter, zach.ware, Alex.Willmer, yan12125, bennykj |
2016-10-27 10:27:11 | xdegaye | set | messageid: <1477564031.44.0.624585611887.issue28444@psf.upfronthosting.co.za> |
2016-10-27 10:27:11 | xdegaye | link | issue28444 messages |
2016-10-27 10:27:11 | xdegaye | create | |
|