Message 278937 - Python tracker

➜

This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

Author	vstinner
Recipients	SilentGhost, ezio.melotti, mrabarnett, rhettinger, serhiy.storchaka, vstinner, xiang.zhang
Date	2016-10-18.21:12:47
SpamBayes Score	-1.0
Marked as misclassified	Yes
Message-id	<1476825167.86.0.178574949979.issue28293@psf.upfronthosting.co.za>
In-reply-to

Content
re_cache_ordered_dict_popitem.patch: LGTM, it can be pushed to the default branch. -- "This is unlikely possible with current API of lru_cache. Testing flags before looking up in a cache adds an overhead." Oh wait, I looked at the code and this case is complex because the function depends on the current locale if the LOCALE flag is set... A lookup in the the cache requires to get the current locale, but not if the LOCALE flag is not set... It seems too complex for @lru_cache().

re_cache_ordered_dict_popitem.patch: LGTM, it can be pushed to the default branch.

--

"This is unlikely possible with current API of lru_cache. Testing flags before looking up in a cache adds an overhead."

Oh wait, I looked at the code and this case is complex because the function depends on the current locale if the LOCALE flag is set... A lookup in the the cache requires to get the current locale, but not if the LOCALE flag is not set... It seems too complex for @lru_cache().

History
Date	User	Action	Args
2016-10-18 21:12:47	vstinner	set	recipients: + vstinner, rhettinger, ezio.melotti, mrabarnett, SilentGhost, serhiy.storchaka, xiang.zhang
2016-10-18 21:12:47	vstinner	set	messageid: <1476825167.86.0.178574949979.issue28293@psf.upfronthosting.co.za>
2016-10-18 21:12:47	vstinner	link	issue28293 messages
2016-10-18 21:12:47	vstinner	create