This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

Author rhettinger
Recipients rhettinger, serhiy.storchaka
Date 2016-10-10.02:17:38
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <1476065859.95.0.0900228045201.issue28397@psf.upfronthosting.co.za>
In-reply-to
Content
Don't change the code in the collections module.  While semantically valid, the change obfuscates the code.  The meaning of maxlen < 0 is that there is no maximum length.  I don't want this test hidden; otherwise, I would have changed it long ago as was done elsewhere in the module where it made sense.

Elsewhere, consider making a macro with clear name and comment (as was done with NEEDS_TRIM) in the collections module.  Otherwise, you're just leaving behind constipated and tricky code with no indication of why a signed variable is being coerced to unsigned.
History
Date User Action Args
2016-10-10 02:17:40rhettingersetrecipients: + rhettinger, serhiy.storchaka
2016-10-10 02:17:39rhettingersetmessageid: <1476065859.95.0.0900228045201.issue28397@psf.upfronthosting.co.za>
2016-10-10 02:17:39rhettingerlinkissue28397 messages
2016-10-10 02:17:39rhettingercreate