Message278397
Don't change the code in the collections module. While semantically valid, the change obfuscates the code. The meaning of maxlen < 0 is that there is no maximum length. I don't want this test hidden; otherwise, I would have changed it long ago as was done elsewhere in the module where it made sense.
Elsewhere, consider making a macro with clear name and comment (as was done with NEEDS_TRIM) in the collections module. Otherwise, you're just leaving behind constipated and tricky code with no indication of why a signed variable is being coerced to unsigned. |
|
Date |
User |
Action |
Args |
2016-10-10 02:17:40 | rhettinger | set | recipients:
+ rhettinger, serhiy.storchaka |
2016-10-10 02:17:39 | rhettinger | set | messageid: <1476065859.95.0.0900228045201.issue28397@psf.upfronthosting.co.za> |
2016-10-10 02:17:39 | rhettinger | link | issue28397 messages |
2016-10-10 02:17:39 | rhettinger | create | |
|