This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

Author mark.dickinson
Recipients mark.dickinson, ned.deily, steven.daprano
Date 2016-10-01.12:33:54
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <1475325234.65.0.257375698668.issue28328@psf.upfronthosting.co.za>
In-reply-to
Content
The newly-added statistics.geometric_mean function appears to have no tests at all, with the exception of a single doctest:

    >>> geometric_mean([1.10, 0.95, 1.12])
    1.0538483123382172

Steve, Ned: what do you think about taking geometric_mean out of Python 3.6, leaving us time to get it into shape for 3.7? The implementation of geometric_mean is complicated, with many edge cases. The original code was committed without review in #27181, and it currently suffers from some serious bugs: see #27761, #28111, #28327 (the first of these affects only the tests for nroot; the second and third are behaviour bugs in geometric_mean). With the lack of tests, and Python 3.6 b2 looming, I think the best thing to do might be to defer the inclusion of geometric_mean to Python 3.7.

I'll mark this as a release blocker until we decide what to do.
History
Date User Action Args
2016-10-01 12:33:54mark.dickinsonsetrecipients: + mark.dickinson, ned.deily, steven.daprano
2016-10-01 12:33:54mark.dickinsonsetmessageid: <1475325234.65.0.257375698668.issue28328@psf.upfronthosting.co.za>
2016-10-01 12:33:54mark.dickinsonlinkissue28328 messages
2016-10-01 12:33:54mark.dickinsoncreate