Message277088
General comment on the patch: I believe per PEP7, we're still sticking to ANSI C (aka C89), and specifically, "all declarations must be at the top of a block (not necessarily at the top of function".
The patch assumes lax standards compliance (or C99+ compliance), declaring variables in the for loop initializer section and midway through blocks. This should be changed to declare all variables at the top of blocks, and not in for loop initializer sections. |
|
Date |
User |
Action |
Args |
2016-09-21 04:18:59 | josh.r | set | recipients:
+ josh.r, tim.peters, rhettinger, methane, serhiy.storchaka |
2016-09-21 04:18:59 | josh.r | set | messageid: <1474431539.56.0.230785799893.issue28201@psf.upfronthosting.co.za> |
2016-09-21 04:18:59 | josh.r | link | issue28201 messages |
2016-09-21 04:18:59 | josh.r | create | |
|