Author bmispelon
Recipients belopolsky, berker.peksag, bmispelon, rhettinger, serhiy.storchaka, taleinat
Date 2016-09-20.08:02:25
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <1474358546.78.0.610046249501.issue24416@psf.upfronthosting.co.za>
In-reply-to
Content
I updated the patch based on Raymond's feedback.

I don't know C at all and I tried to mimic the namedtuple usage of timemodule.c as much as I could (until the code compiled and the test suite passed).

I still have two questions:

* It seems that the Python implementation (Lib/datetime.py) is not tested when I run `./python -m test test_datetime` (I introduced a deliberate error in datetime.isocalendar() there but the test still succeeded). Is there a particular procedure to trigger those tests?

* I'm currently using the name `IsoCalendarDate` as suggested by user taleinat. However, shouldn't it be `ISOCalendarDate`?

Thanks.
History
Date User Action Args
2016-09-20 08:02:26bmispelonsetrecipients: + bmispelon, rhettinger, belopolsky, taleinat, berker.peksag, serhiy.storchaka
2016-09-20 08:02:26bmispelonsetmessageid: <1474358546.78.0.610046249501.issue24416@psf.upfronthosting.co.za>
2016-09-20 08:02:26bmispelonlinkissue24416 messages
2016-09-20 08:02:26bmispeloncreate