Message276866
Personally, I’m not too enthusiastic, because it is rather magical, and does not work in all cases. It seems more like a feature than a bug fix. But I have rarely used the fileno=... parameter, and it shouldn’t have much negative impact, so I’m not too fussed.
According to Issue 27377, these are some cases where parts won’t work:
* Windows and OS X (and older versions of Linux and BSD) don’t have SO_PROTOCOL
* getsockname() not guaranteed to work on unbound sockets, especially on Windows, and Free BSD with SCTP sockets
Also, if we are going to read SO_PROTOCOL when fileno=... is given, why not also read it in the normal case when proto=0 (unspecified) is given? |
|
Date |
User |
Action |
Args |
2016-09-18 01:28:41 | martin.panter | set | recipients:
+ martin.panter, christian.heimes, r.david.murray |
2016-09-18 01:28:41 | martin.panter | set | messageid: <1474162121.29.0.0619870297991.issue28134@psf.upfronthosting.co.za> |
2016-09-18 01:28:41 | martin.panter | link | issue28134 messages |
2016-09-18 01:28:40 | martin.panter | create | |
|