Author martin.panter
Recipients benjamin.peterson, malthe, martin.panter, r.david.murray
Date 2016-09-16.01:34:32
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <1473989673.07.0.0309881851661.issue28143@psf.upfronthosting.co.za>
In-reply-to
Content
It seems a terrible idea to require Python 3 to be installed in order to regenerate the boot files for a Python 2 build. Maybe if we can figure out the minimum installed Python version expected for these ASDL scripts in 2.7, and maintain that while adding Python 3 support. But even that seems risky.

Your changes obviously make the files incompatible with Python 2:

print()  # Prints an empty tuple
print("Error visiting", repr(object))  # Prints a 2-tuple
f = open(p, "w")  # Writes CRLFs on Windows (I think; it’s been a while)

If we do go down this road, it may be worth looking at what has already been done to the corresponding scripts in Python 3.

But you may not actually need to regenerate the files. If you are building from the source directory, try “make touch” after generating the makefile. In general, try “touch Include/Python-ast.h Python/Python-ast.c”.

I would like to see this be made easier for both Python 2 and 3. I suggested some other ideas in Issue 23404.
History
Date User Action Args
2016-09-16 01:34:33martin.pantersetrecipients: + martin.panter, benjamin.peterson, r.david.murray, malthe
2016-09-16 01:34:33martin.pantersetmessageid: <1473989673.07.0.0309881851661.issue28143@psf.upfronthosting.co.za>
2016-09-16 01:34:33martin.panterlinkissue28143 messages
2016-09-16 01:34:32martin.pantercreate