Message276633
I've attached a potential fix for this issue.
While trying to fix this, I noticed that I coudn't assume that I just need to ensure that each line has a newline. If I always ensure each line in diffline has a newline, then the fourth test in testAssertMultilineEqual (in Lib/unittest/test/test_assertions.py) fails because standardMsg in assertMultiLineEqual in Lib/unittest/case.py is just one line without a newline. To sidestep this problem, I made it so that I only ensure there is a newline for each line if and only if there is more than one line in difflines. However, I'm not sure that I can assume there should be a newline in cases similar to the fourth test (where longMessage is set to true and a 'msg' is passed) in testAssertMultilineEqual but where there is more than one line in standardMsg in assertMultiLineEqual. |
|
Date |
User |
Action |
Args |
2016-09-15 22:29:39 | adchanw | set | recipients:
+ adchanw, rbcollins, ezio.melotti, r.david.murray, michael.foord, chris.jerdonek, Elena.Oat, anish.shah, pynewbie |
2016-09-15 22:29:38 | adchanw | set | messageid: <1473978578.91.0.248850331347.issue24780@psf.upfronthosting.co.za> |
2016-09-15 22:29:38 | adchanw | link | issue24780 messages |
2016-09-15 22:29:38 | adchanw | create | |
|