Author eryksun
Recipients eryksun, paul.moore, steve.dower, tim.golden, zach.ware
Date 2016-09-15.03:24:21
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <1473909865.01.0.166181984624.issue28161@psf.upfronthosting.co.za>
In-reply-to
Content
When opening the CON device the underlying CreateFile call needs to use either GENERIC_READ or GENERIC_WRITE access, but not both. Currently opening for writing fails as follows:

   >>> open('CON', 'wb', buffering=0)
   Traceback (most recent call last):
      File "<stdin>", line 1, in <module>
   OSError: [WinError 87] The parameter is incorrect: 'CON'

If self->writable is true, it should set `access = GENERIC_WRITE`, not `access |= GENERIC_WRITE`.

This only applies to CON. It's normal to open CONIN$ and CONOUT$ with both read and write access, and WindowsConsoleIO handles that correctly.
History
Date User Action Args
2016-09-15 03:24:25eryksunsetrecipients: + eryksun, paul.moore, tim.golden, zach.ware, steve.dower
2016-09-15 03:24:25eryksunsetmessageid: <1473909865.01.0.166181984624.issue28161@psf.upfronthosting.co.za>
2016-09-15 03:24:24eryksunlinkissue28161 messages
2016-09-15 03:24:21eryksuncreate