This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

Author sjt
Recipients ned.deily, serhiy.storchaka, sjt
Date 2016-09-11.20:28:39
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <1473625720.21.0.635694205594.issue28080@psf.upfronthosting.co.za>
In-reply-to
Content
Re: wait for 3.7 if reviewers are busy, understood.  N.B. Contributor agreement is now on file (I received the PDF from python.org already).

Re: existing patches:
My patch is very similar in the basic approach to Sergey Dorofeev's patch in issue10614.  Main differences:
(1) Sergey's patch treats the "encoding" parameter as a first class citizen with a default to cp437, whereas mine treats it as a special case defaulting to None, with utf-8 and cp437 getting special treatment as the standard encodings.  Subtle point, but I like it this way.
(2) My patch includes support for the argument in the __main__ script.
(3) Sergey's patch misses one execution path in the current code so needs update before application.

The Japanese patches by umedoblock are very Japanese-centric, and worse, they try to guess the encoding by the crude method of seeing what decodes successfully.  They are not acceptable IMO.

Aaargh.  Just noticed the Japanese in test_zipfile.py.  Will change it to use \u escapes soon.
History
Date User Action Args
2016-09-11 20:28:40sjtsetrecipients: + sjt, ned.deily, serhiy.storchaka
2016-09-11 20:28:40sjtsetmessageid: <1473625720.21.0.635694205594.issue28080@psf.upfronthosting.co.za>
2016-09-11 20:28:40sjtlinkissue28080 messages
2016-09-11 20:28:39sjtcreate