Author ammar2
Recipients Jelle Zijlstra, ammar2, berker.peksag, docs@python, eric.araujo, ezio.melotti, georg.brandl, r.david.murray, zach.ware
Date 2016-09-09.20:05:19
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <1473451520.41.0.352321541128.issue19489@psf.upfronthosting.co.za>
In-reply-to
Content
>The latter. All of the popular browsers (Chrome, Firefox, Edge and even Safari) already support the placeholder attribute so I think we can safely ignore IE 8 :)

Roger, I've changed it to placeholder.


>I know this is basically a copy of upstream searchbox.html, but we can probably remove ``style="display: none"`` and ``$('.inline-search').show(0);``.

The reason that exists is because sphinx's search relies on javascript.


>inline-search doesn't seem to be necessary here. ``display: inline`` is already applied by ``div.related li``.

Good catch, I've removed the class from there.
History
Date User Action Args
2016-09-09 20:05:20ammar2setrecipients: + ammar2, georg.brandl, ezio.melotti, eric.araujo, r.david.murray, docs@python, berker.peksag, zach.ware, Jelle Zijlstra
2016-09-09 20:05:20ammar2setmessageid: <1473451520.41.0.352321541128.issue19489@psf.upfronthosting.co.za>
2016-09-09 20:05:20ammar2linkissue19489 messages
2016-09-09 20:05:20ammar2create