Author martin.panter
Recipients Arfrever, amaury.forgeotdarc, berwin22, chris.jerdonek, haypo, mark, martin.panter, merwok, mightyiam, ncoghlan, pitrou, r.david.murray, segfaulthunter, srid, steve.dower
Date 2016-09-06.03:54:19
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <1473134059.35.0.238963184101.issue6135@psf.upfronthosting.co.za>
In-reply-to
Content
Would be nice to see tests for getstatusoutput() and the errors parameter. Also you need more error handling e.g. if the encoding is unsupported, I think the internal pipe files won’t be cleaned up.

Also, should encoding=... or errors=... be an error if universal_newlines=False (the default)?
History
Date User Action Args
2016-09-06 03:54:19martin.pantersetrecipients: + martin.panter, amaury.forgeotdarc, ncoghlan, pitrou, haypo, mark, merwok, segfaulthunter, Arfrever, r.david.murray, srid, mightyiam, chris.jerdonek, steve.dower, berwin22
2016-09-06 03:54:19martin.pantersetmessageid: <1473134059.35.0.238963184101.issue6135@psf.upfronthosting.co.za>
2016-09-06 03:54:19martin.panterlinkissue6135 messages
2016-09-06 03:54:19martin.pantercreate