This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

Author berker.peksag
Recipients berker.peksag, docs@python, vstinner, xiang.zhang
Date 2016-08-19.15:45:35
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <1471621535.71.0.546849159861.issue27740@psf.upfronthosting.co.za>
In-reply-to
Content
I don't understand the second part of the patch.

    *filename* is a filesystem encoding (:func:`os.fsdecode`) encoded string [...]

Do you want to document that filename should be encoded by using PyUnicode_EncodeFSDefault *before* passing it to Py_CompileStringExFlags (you will probably need to wrap it with something like PyBytes_AsString too)? If so, I think the os.fsdecode() part needs to be changed to os.fsencode().

I think the current wording is saying that filename is going to be decoded inside of Py_CompileStringExFlags (which is also correct.)
History
Date User Action Args
2016-08-19 15:45:35berker.peksagsetrecipients: + berker.peksag, vstinner, docs@python, xiang.zhang
2016-08-19 15:45:35berker.peksagsetmessageid: <1471621535.71.0.546849159861.issue27740@psf.upfronthosting.co.za>
2016-08-19 15:45:35berker.peksaglinkissue27740 messages
2016-08-19 15:45:35berker.peksagcreate