Message273137
I don't understand the second part of the patch.
*filename* is a filesystem encoding (:func:`os.fsdecode`) encoded string [...]
Do you want to document that filename should be encoded by using PyUnicode_EncodeFSDefault *before* passing it to Py_CompileStringExFlags (you will probably need to wrap it with something like PyBytes_AsString too)? If so, I think the os.fsdecode() part needs to be changed to os.fsencode().
I think the current wording is saying that filename is going to be decoded inside of Py_CompileStringExFlags (which is also correct.) |
|
Date |
User |
Action |
Args |
2016-08-19 15:45:35 | berker.peksag | set | recipients:
+ berker.peksag, vstinner, docs@python, xiang.zhang |
2016-08-19 15:45:35 | berker.peksag | set | messageid: <1471621535.71.0.546849159861.issue27740@psf.upfronthosting.co.za> |
2016-08-19 15:45:35 | berker.peksag | link | issue27740 messages |
2016-08-19 15:45:35 | berker.peksag | create | |
|