Author mark.dickinson
Recipients mark.dickinson, martin.panter, rhettinger, tim.peters, xiang.zhang
Date 2016-08-19.08:29:36
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <1471595376.53.0.828619159629.issue27662@psf.upfronthosting.co.za>
In-reply-to
Content
Right, sorry. I'm suggesting dropping that second assertion entirely; essentially, we're moving the responsibility for and knowledge about overflow checking into the PyMem_* functions/macros (which is where it belongs), and I don't see a need to check the equivalent condition in list_ass_subscript.

If you do keep the second assertion, you should probably drop the `(size_t)` cast, so that we're not comparing signed with unsigned.
History
Date User Action Args
2016-08-19 08:29:36mark.dickinsonsetrecipients: + mark.dickinson, tim.peters, rhettinger, martin.panter, xiang.zhang
2016-08-19 08:29:36mark.dickinsonsetmessageid: <1471595376.53.0.828619159629.issue27662@psf.upfronthosting.co.za>
2016-08-19 08:29:36mark.dickinsonlinkissue27662 messages
2016-08-19 08:29:36mark.dickinsoncreate