Message272977
Thanks Petr. I'd appreciate it if you are willing to review the patch.
Upload a patch to fix this, along with tests and doc updating.
But here is something different. In PEP489, it is explicitly stated that "Py_mod_create slot is not responsible for setting import-related attributes specified in PEP 451 (such as __name__ or __loader__ ) on the new module". So when an object(even ModuleType instances) is returned, it's __name__ attribute is not set and we can't rely on it (which means we can't even use PyModule_GetNameObject). I then use the name attribute of the spec. Looking forward to feedback. |
|
Date |
User |
Action |
Args |
2016-08-17 17:50:03 | xiang.zhang | set | recipients:
+ xiang.zhang, ncoghlan, petr.viktorin |
2016-08-17 17:50:02 | xiang.zhang | set | messageid: <1471456202.99.0.656043774676.issue27782@psf.upfronthosting.co.za> |
2016-08-17 17:50:02 | xiang.zhang | link | issue27782 messages |
2016-08-17 17:50:02 | xiang.zhang | create | |
|