Author martin.panter
Recipients Rotkraut, demian.brecht, harobed, haypo, martin.panter, matrixise, orsenthil, petri.lehtinen, piotr.dobrogost, pitrou, whitemice
Date 2016-08-17.13:21:44
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <1471440109.07.0.955782996815.issue12319@psf.upfronthosting.co.za>
In-reply-to
Content
Patch 12 has the following changes:

* Change the chunked_encoding parameter to keyword-only
* Drop most of the change regarding the UpdatingFile test (see code review)
* Update the urlopen() TypeError to mention “data” may be a file object
* Fix and update the tests (they weren’t actually being run)
* Various minor documentation corrections, e.g. wrong parameter name.

I think there are a few of my comments to Demian’s patches that are still relevant, but they are just opportunities for improving the code (e.g. making the chunking iteration more efficient and readable). This version is hopefully “good enough”.
History
Date User Action Args
2016-08-17 13:21:53martin.pantersetrecipients: + martin.panter, orsenthil, pitrou, haypo, harobed, petri.lehtinen, piotr.dobrogost, demian.brecht, matrixise, whitemice, Rotkraut
2016-08-17 13:21:49martin.pantersetmessageid: <1471440109.07.0.955782996815.issue12319@psf.upfronthosting.co.za>
2016-08-17 13:21:49martin.panterlinkissue12319 messages
2016-08-17 13:21:48martin.pantercreate