Author terry.reedy
Recipients martin.panter, python-dev, serhiy.storchaka, terry.reedy, zach.ware
Date 2016-08-16.15:55:46
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <1471362947.05.0.524950027464.issue27611@psf.upfronthosting.co.za>
In-reply-to
Content
This issue is about test_tix failing when run after test_idle, due to the conjunction of two specific causes, one old (tix importing _default_root), one new (IDLE deleting and not restoring _default_root).  The new cause exposed the old.  Fixing either cause would have negated the conjunction, but at Zack's urging, I fixed both.  I even did one extra bit of cleanup in moving the tkinter and os imports to the top where they belong.  In my view, my patch was more than complete and this issue is fixed and should have remained closed and should be reclosed.

Serhiy, when I wrote the tix patch, I was aware that tix remains buggy in that it will fail if a *user* imports tix, removes _default_root, and calls either of the functions that unconditionally access the attribute.  Since test_tix only tests that the tix can be imported and that tix.Tk runs, there may be more bugs.  And more cleanups might be needed.  However, patching tix to work better is a different issue than this one.  If you want, open a new issue, add some tests, and write the patch you outlined.
History
Date User Action Args
2016-08-16 15:55:47terry.reedysetrecipients: + terry.reedy, python-dev, martin.panter, zach.ware, serhiy.storchaka
2016-08-16 15:55:47terry.reedysetmessageid: <1471362947.05.0.524950027464.issue27611@psf.upfronthosting.co.za>
2016-08-16 15:55:47terry.reedylinkissue27611 messages
2016-08-16 15:55:46terry.reedycreate