Author orsenthil
Recipients Rotkraut, demian.brecht, harobed, haypo, martin.panter, orsenthil, petri.lehtinen, piotr.dobrogost, pitrou, whitemice
Date 2016-08-10.08:49:15
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <1470818955.71.0.867580214306.issue12319@psf.upfronthosting.co.za>
In-reply-to
Content
(Assigning this to Martin)

I really like this patch, and I support that we land this before the feature freeze of 3.6. 

As along as the API interface to users is simple, the changes internal to _send_output should not be a concern. Yeah, I agree that multiple things needs to be taken care, but it is alright.

Also, +1 to do validation of transfer-encoding usage as it's done by the patch. This is along the lines of RFC recommendation and it is better to fail early than let the server implementation be the decider. 

I would like to know the better suggestion for "testing text" too. (Adding haypo to steer us here) Although, I would point out that the static method has a generic name _is_textIO, while relying on .read attribute which is checked outside the static method.
History
Date User Action Args
2016-08-10 08:49:15orsenthilsetrecipients: + orsenthil, pitrou, haypo, harobed, petri.lehtinen, martin.panter, piotr.dobrogost, demian.brecht, whitemice, Rotkraut
2016-08-10 08:49:15orsenthilsetmessageid: <1470818955.71.0.867580214306.issue12319@psf.upfronthosting.co.za>
2016-08-10 08:49:15orsenthillinkissue12319 messages
2016-08-10 08:49:15orsenthilcreate