This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

Author berker.peksag
Recipients JelleZijlstra, ammar2, berker.peksag, docs@python, eric.araujo, ezio.melotti, georg.brandl, zach.ware
Date 2016-08-09.23:34:31
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <>
This looks pretty good to me, thanks! I have two minor suggestions:

1. It would be better to make "Quick search" a placeholder:

   <input type="text" name="q" placeholder="{{ _('Quick search') }}" />

2. <li class="right"> will add an unnecessary border in search page. I'd change it to

   <li{%- if pagename != "search" and builder != "singlehtml" %} class="right"{% endif %}>


    +form.inline-search input {
    +    display: inline;

may cause weird compatibility problems in some (old?) browsers. We can change it to use display: inline-block instead.

Is there a way to send this to upstream Sphinx?
Date User Action Args
2016-08-09 23:34:31berker.peksagsetrecipients: + berker.peksag, georg.brandl, ezio.melotti, eric.araujo, docs@python, zach.ware, JelleZijlstra, ammar2
2016-08-09 23:34:31berker.peksagsetmessageid: <>
2016-08-09 23:34:31berker.peksaglinkissue19489 messages
2016-08-09 23:34:31berker.peksagcreate