Author berker.peksag
Recipients Jelle Zijlstra, ammar2, berker.peksag, docs@python, eric.araujo, ezio.melotti, georg.brandl, zach.ware
Date 2016-08-09.23:34:31
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <1470785671.39.0.169387408193.issue19489@psf.upfronthosting.co.za>
In-reply-to
Content
This looks pretty good to me, thanks! I have two minor suggestions:

1. It would be better to make "Quick search" a placeholder:

   <input type="text" name="q" placeholder="{{ _('Quick search') }}" />

2. <li class="right"> will add an unnecessary border in search page. I'd change it to

   <li{%- if pagename != "search" and builder != "singlehtml" %} class="right"{% endif %}>

Also,

    +form.inline-search input {
    +    display: inline;
    +}

may cause weird compatibility problems in some (old?) browsers. We can change it to use display: inline-block instead.

Is there a way to send this to upstream Sphinx?
History
Date User Action Args
2016-08-09 23:34:31berker.peksagsetrecipients: + berker.peksag, georg.brandl, ezio.melotti, eric.araujo, docs@python, zach.ware, Jelle Zijlstra, ammar2
2016-08-09 23:34:31berker.peksagsetmessageid: <1470785671.39.0.169387408193.issue19489@psf.upfronthosting.co.za>
2016-08-09 23:34:31berker.peksaglinkissue19489 messages
2016-08-09 23:34:31berker.peksagcreate