Author christian.heimes
Recipients Michael.Felt, alex, christian.heimes, dstufft, giampaolo.rodola, janssen, matrixise, pitrou, smpeepers, spil, zach.ware
Date 2016-08-08.12:47:10
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <1470660432.82.0.209082485997.issue26470@psf.upfronthosting.co.za>
In-reply-to
Content
St├ęphane, I have addressed your code review.

def __new__() no longer hard-codes protocol. We can change that in a later version of Python. OpenSSL has deprecated all SSL methods except of the generic TLS method. The TLS method was formerly known as SSLv23 method and does auto-negotiation of the latest supported method.

Lib/test/test_ssl.py:1183: LibreSSL does not support SSL_CA_PATH and SSL_CA_DIR env vars. I have changed the comment on the test.

Modules/_hashopenssl.c:127: _hashopenssl.c now does error checks on EVP digest copy. The copy operation can fail when an EVP ENGINE is involved.

HAS_FAST_PKCS5_PBKDF2_HMAC is defined in _hashopenssl.c. OpenSSL used to have a bad implementation of PKBDF2. I fixed it in 2013. The workaround is no longer required for OpenSSL >= 1.1.0. You can find more details in https://jbp.io/2015/08/11/pbkdf2-performance-matters/
History
Date User Action Args
2016-08-08 12:47:14christian.heimessetrecipients: + christian.heimes, janssen, pitrou, giampaolo.rodola, alex, zach.ware, dstufft, matrixise, spil, Michael.Felt, smpeepers
2016-08-08 12:47:12christian.heimessetmessageid: <1470660432.82.0.209082485997.issue26470@psf.upfronthosting.co.za>
2016-08-08 12:47:12christian.heimeslinkissue26470 messages
2016-08-08 12:47:12christian.heimescreate