Message271865
TL;DR - We really need reliable tests for the exact behavior we want before coming up with patches.
attached is a patch (-gps01) that would do the same thing as Lib/smtpd.py does... But I'm not convinced it is a good idea.
Would forcing a socket.getaddrinfo() call from the constructor cause problems? This would be new behavior over what TCPServer did in the past. Could it trigger a blocking reverse DNS lookup where there wasn't one in the past?
What about when server_address[0] is ''? getaddrinfo() fails on that, but the existing code works and binds to 0.0.0.0. Presumably this should bind via AF_INET6 if the host supports it but a simple getaddrinfo() call doesn't tell us that. |
|
Date |
User |
Action |
Args |
2016-08-02 23:23:57 | gregory.p.smith | set | recipients:
+ gregory.p.smith, r.david.murray, neologix, berker.peksag, martin.panter, jleedev, dazhaoyu, andreasr, Carlos.Ralli |
2016-08-02 23:23:57 | gregory.p.smith | set | messageid: <1470180237.46.0.974562764109.issue20215@psf.upfronthosting.co.za> |
2016-08-02 23:23:57 | gregory.p.smith | link | issue20215 messages |
2016-08-02 23:23:57 | gregory.p.smith | create | |
|