Author gregory.p.smith
Recipients Carlos.Ralli, andreasr, berker.peksag, dazhaoyu, gregory.p.smith, jleedev, martin.panter, neologix, r.david.murray
Date 2016-08-02.23:23:56
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <1470180237.46.0.974562764109.issue20215@psf.upfronthosting.co.za>
In-reply-to
Content
TL;DR - We really need reliable tests for the exact behavior we want before coming up with patches.

attached is a patch (-gps01) that would do the same thing as Lib/smtpd.py does... But I'm not convinced it is a good idea.

Would forcing a socket.getaddrinfo() call from the constructor cause problems?  This would be new behavior over what TCPServer did in the past.  Could it trigger a blocking reverse DNS lookup where there wasn't one in the past?

What about when server_address[0] is ''?  getaddrinfo() fails on that, but the existing code works and binds to 0.0.0.0.  Presumably this should bind via AF_INET6 if the host supports it but a simple getaddrinfo() call doesn't tell us that.
History
Date User Action Args
2016-08-02 23:23:57gregory.p.smithsetrecipients: + gregory.p.smith, r.david.murray, neologix, berker.peksag, martin.panter, jleedev, dazhaoyu, andreasr, Carlos.Ralli
2016-08-02 23:23:57gregory.p.smithsetmessageid: <1470180237.46.0.974562764109.issue20215@psf.upfronthosting.co.za>
2016-08-02 23:23:57gregory.p.smithlinkissue20215 messages
2016-08-02 23:23:57gregory.p.smithcreate