Author martin.panter
Recipients Jeffrey.Walton, alex, alexandre.vassalotti, christian.heimes, deadshort, dmalcolm, donmez, fweimer, jcea, jwilk, loewis, mark.dickinson, martin.panter, matejcik, nnorwitz, pitrou, python-dev, serhiy.storchaka, vstinner, xiang.zhang, ztane
Date 2016-08-02.03:20:51
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <1470108051.99.0.343762074803.issue1621@psf.upfronthosting.co.za>
In-reply-to
Content
Looking over r60793, the overflow check at Modules/cjkcodecs/multibytecodec.c:836 looks vulnerable to being optimized away, because it can only detect the overflow if the line above has already overflowed. Perhaps change PY_SSIZE_T_MAX to MAXDECPENDING. I wonder if any of the GCC optimization and warning modes can detect this case?

Also, Python/ast.c:3988 checks using PY_SIZE_MAX, but then passes the value to PyBytes_FromStringAndSize(), which expects ssize_t and in the best case would raise SystemError.
History
Date User Action Args
2016-08-02 03:20:52martin.pantersetrecipients: + martin.panter, loewis, nnorwitz, jcea, mark.dickinson, pitrou, vstinner, christian.heimes, alexandre.vassalotti, donmez, matejcik, jwilk, alex, dmalcolm, python-dev, deadshort, serhiy.storchaka, ztane, fweimer, Jeffrey.Walton, xiang.zhang
2016-08-02 03:20:51martin.pantersetmessageid: <1470108051.99.0.343762074803.issue1621@psf.upfronthosting.co.za>
2016-08-02 03:20:51martin.panterlinkissue1621 messages
2016-08-02 03:20:51martin.pantercreate