Message271800
Looking over r60793, the overflow check at Modules/cjkcodecs/multibytecodec.c:836 looks vulnerable to being optimized away, because it can only detect the overflow if the line above has already overflowed. Perhaps change PY_SSIZE_T_MAX to MAXDECPENDING. I wonder if any of the GCC optimization and warning modes can detect this case?
Also, Python/ast.c:3988 checks using PY_SIZE_MAX, but then passes the value to PyBytes_FromStringAndSize(), which expects ssize_t and in the best case would raise SystemError. |
|
Date |
User |
Action |
Args |
2016-08-02 03:20:52 | martin.panter | set | recipients:
+ martin.panter, loewis, nnorwitz, jcea, mark.dickinson, pitrou, vstinner, christian.heimes, alexandre.vassalotti, donmez, matejcik, jwilk, alex, dmalcolm, python-dev, deadshort, serhiy.storchaka, ztane, fweimer, Jeffrey.Walton, xiang.zhang |
2016-08-02 03:20:51 | martin.panter | set | messageid: <1470108051.99.0.343762074803.issue1621@psf.upfronthosting.co.za> |
2016-08-02 03:20:51 | martin.panter | link | issue1621 messages |
2016-08-02 03:20:51 | martin.panter | create | |
|