➜

This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

Author martin.panter
Recipients Jeffrey.Walton, alex, alexandre.vassalotti, christian.heimes, deadshort, dmalcolm, donmez, fweimer, jcea, jwilk, loewis, mark.dickinson, martin.panter, matejcik, nnorwitz, pitrou, python-dev, serhiy.storchaka, vstinner, xiang.zhang, ztane
Date 2016-08-01.04:25:53
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <1470025554.6.0.702212321678.issue1621@psf.upfronthosting.co.za>
In-reply-to
Content 
The check in ins1() was originally added in revision b9002da46f69. I presume it references the Python-dev thread “can this overflow (list insertion)?” <20000812145155.A7629@ActiveState.com>, <https://marc.info/?l=python-dev&m=107666472818169>. At that time, ob_size was an int, so overflow checking was definitely needed. Later, revision 7fdc639bc5b4 changed ob_size to Py_ssize_t, and then revision 606818c33e50 updated the overflow check from INT_MAX to PY_SSIZE_T_MAX.

BTW I made a small mistake in my previous message. The worst case would be extending a list with itself. But I think the conclusion is still the same.
History
Date User Action Args
2016-08-01 04:25:54martin.pantersetrecipients: + martin.panter, loewis, nnorwitz, jcea, mark.dickinson, pitrou, vstinner, christian.heimes, alexandre.vassalotti, donmez, matejcik, jwilk, alex, dmalcolm, python-dev, deadshort, serhiy.storchaka, ztane, fweimer, Jeffrey.Walton, xiang.zhang
2016-08-01 04:25:54martin.pantersetmessageid: <1470025554.6.0.702212321678.issue1621@psf.upfronthosting.co.za>
2016-08-01 04:25:54martin.panterlinkissue1621 messages
2016-08-01 04:25:53martin.pantercreate