Message271576
That's really nice, thank you for doing this! To get your code reviewed, though, you should upload a patch here. With git, you can do 'git diff > my_patch_file_name.patch' in your local repo, then you can upload the resulting file here. If you haven't done so yet, you'll need to sign a contributor agreement as well: https://www.python.org/psf/contrib/contrib-form/ :)
(Also, you might want to remove the 'index ...' lines in the patch file that git generates for each modified file; since there are three files, there should be three lines to remove. I'm not sure if you really have to, but I always do it just to be sure :) |
|
Date |
User |
Action |
Args |
2016-07-28 18:12:29 | abarry | set | recipients:
+ abarry, lelit |
2016-07-28 18:12:29 | abarry | set | messageid: <1469729549.07.0.728689708538.issue27645@psf.upfronthosting.co.za> |
2016-07-28 18:12:29 | abarry | link | issue27645 messages |
2016-07-28 18:12:28 | abarry | create | |
|