Author ncoghlan
Recipients Rosuav, ebarry, ethan.furman, georg.brandl, ncoghlan, xiang.zhang
Date 2016-07-24.09:01:57
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <1469350917.72.0.501341063519.issue26823@psf.upfronthosting.co.za>
In-reply-to
Content
Thanks Emanuel, and sorry for the long delay in getting a review!

My main substantive comment is that the approach of hardcoding the recursion count won't work cross platform, as the default recursion limit is set differently depending on how the platform's C runtime behaves. Fortunately, sys.getrecursionlimit() and len(inspect.stack()) should make it possible to tweak the tests to avoid the hardcoded assumption.

I also have some additional readability suggestions, which can be found in Rietveld.
History
Date User Action Args
2016-07-24 09:01:57ncoghlansetrecipients: + ncoghlan, georg.brandl, ethan.furman, Rosuav, xiang.zhang, ebarry
2016-07-24 09:01:57ncoghlansetmessageid: <1469350917.72.0.501341063519.issue26823@psf.upfronthosting.co.za>
2016-07-24 09:01:57ncoghlanlinkissue26823 messages
2016-07-24 09:01:57ncoghlancreate