Author brett.cannon
Recipients Decorater, brett.cannon, ethan.furman, serhiy.storchaka, xiang.zhang, ztane
Date 2016-07-14.17:30:58
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <1468517458.63.0.880391737783.issue27512@psf.upfronthosting.co.za>
In-reply-to
Content
The reordering of the tests is unnecessary. Because you both changed the code *and* moved a test you have to be very careful to notice the change, otherwise it just looks like you cut-and-pasted the code to another location. Had you left the test method where it was and just simplified the code then it would be very obvious what you changed and reviewing it would be much easier.
History
Date User Action Args
2016-07-14 17:30:58brett.cannonsetrecipients: + brett.cannon, ethan.furman, serhiy.storchaka, ztane, xiang.zhang, Decorater
2016-07-14 17:30:58brett.cannonsetmessageid: <1468517458.63.0.880391737783.issue27512@psf.upfronthosting.co.za>
2016-07-14 17:30:58brett.cannonlinkissue27512 messages
2016-07-14 17:30:58brett.cannoncreate