Author xiang.zhang
Recipients serhiy.storchaka, xiang.zhang
Date 2016-07-09.16:46:44
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <1468082804.63.0.768933034734.issue27473@psf.upfronthosting.co.za>
In-reply-to
Content
bytes_concat uses following code to check overflow:

size = va.len + vb.len;
if (size < 0): {
    PyErr_NoMemory();
    goto done;
}

This is wrong since signed ints overflow is undefined bahaviour.

But one point is that Python's Makefile defines -fwrapv with gcc and
clang. So I am not sure this needs to be changed or not. But in other
parts of Python code I don't see any overflow check like this. I only
see pre-calculated overflow checks.
History
Date User Action Args
2016-07-09 16:46:44xiang.zhangsetrecipients: + xiang.zhang, serhiy.storchaka
2016-07-09 16:46:44xiang.zhangsetmessageid: <1468082804.63.0.768933034734.issue27473@psf.upfronthosting.co.za>
2016-07-09 16:46:44xiang.zhanglinkissue27473 messages
2016-07-09 16:46:44xiang.zhangcreate