Message270053
bytes_concat uses following code to check overflow:
size = va.len + vb.len;
if (size < 0): {
PyErr_NoMemory();
goto done;
}
This is wrong since signed ints overflow is undefined bahaviour.
But one point is that Python's Makefile defines -fwrapv with gcc and
clang. So I am not sure this needs to be changed or not. But in other
parts of Python code I don't see any overflow check like this. I only
see pre-calculated overflow checks. |
|
Date |
User |
Action |
Args |
2016-07-09 16:46:44 | xiang.zhang | set | recipients:
+ xiang.zhang, serhiy.storchaka |
2016-07-09 16:46:44 | xiang.zhang | set | messageid: <1468082804.63.0.768933034734.issue27473@psf.upfronthosting.co.za> |
2016-07-09 16:46:44 | xiang.zhang | link | issue27473 messages |
2016-07-09 16:46:44 | xiang.zhang | create | |
|