This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

Author xiang.zhang
Recipients serhiy.storchaka, xiang.zhang
Date 2016-07-09.16:46:44
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <>
bytes_concat uses following code to check overflow:

size = va.len + vb.len;
if (size < 0): {
    goto done;

This is wrong since signed ints overflow is undefined bahaviour.

But one point is that Python's Makefile defines -fwrapv with gcc and
clang. So I am not sure this needs to be changed or not. But in other
parts of Python code I don't see any overflow check like this. I only
see pre-calculated overflow checks.
Date User Action Args
2016-07-09 16:46:44xiang.zhangsetrecipients: + xiang.zhang, serhiy.storchaka
2016-07-09 16:46:44xiang.zhangsetmessageid: <>
2016-07-09 16:46:44xiang.zhanglinkissue27473 messages
2016-07-09 16:46:44xiang.zhangcreate