Author lesha
Recipients Connor.Wolf, Giovanni.Bajo, bobbyi, dan.oreilly, emptysquare, forest_atq, gregory.p.smith, ionelmc, jcea, lesha, neologix, nirai, nirs, pitrou, sbt, sdaoden, tshepang, vinay.sajip, vstinner
Date 2016-07-09.04:19:05
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <1468037946.07.0.200031592454.issue6721@psf.upfronthosting.co.za>
In-reply-to
Content
On a moment's reflection, a lot of my prior comment is wrong. Sorry about that. 

- glog does not, that I know of, sanitize locks on fork. You just shouldn't log after fork but before exec.

- Using `pthread_atfork` to clean up the `logging` lock might be enough to make it safe from the "just forked" context, but without adding fairly exhaustive tests around this logic, it would be fragile with respect to further improvements to `logging`. So even just making this one library safe is a considerable amount of work.

So I retract most of my previous opinion. Sorry.
History
Date User Action Args
2016-07-09 04:19:06leshasetrecipients: + lesha, gregory.p.smith, vinay.sajip, jcea, nirs, pitrou, vstinner, nirai, forest_atq, ionelmc, bobbyi, neologix, Giovanni.Bajo, sdaoden, tshepang, sbt, emptysquare, dan.oreilly, Connor.Wolf
2016-07-09 04:19:06leshasetmessageid: <1468037946.07.0.200031592454.issue6721@psf.upfronthosting.co.za>
2016-07-09 04:19:06leshalinkissue6721 messages
2016-07-09 04:19:05leshacreate