Author terry.reedy
Recipients serhiy.storchaka, terry.reedy
Date 2016-07-04.20:09:50
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <1467662991.07.0.187758431637.issue27452@psf.upfronthosting.co.za>
In-reply-to
Content
The config module code can be improved even without changing behavior. While working on #27380, I noticed these two:

IdleUserConfParser.RemoveFile is a simple one-liner called once.  Put it inline.

IdleConf.CreateConfigHandlers: A) As near as I can tell, __file__ is now always the absolute path of the file regardless if executed directly or imported.  B) Creating two dicts of file names that are immediately used and deleted is useless and to me makes the code less readable.

I intend these changes only for 3.6 and will not apply until after the new unix keys patch.  Serhiy, have you noticed any similar cleanups that would be appropriate to add?
History
Date User Action Args
2016-07-04 20:09:51terry.reedysetrecipients: + terry.reedy, serhiy.storchaka
2016-07-04 20:09:51terry.reedysetmessageid: <1467662991.07.0.187758431637.issue27452@psf.upfronthosting.co.za>
2016-07-04 20:09:50terry.reedylinkissue27452 messages
2016-07-04 20:09:50terry.reedycreate