Author serhiy.storchaka
Recipients Demur Rumed, Mark.Shannon, haypo, serhiy.storchaka
Date 2016-07-01.21:11:46
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <1467407506.89.0.000861799593255.issue27213@psf.upfronthosting.co.za>
In-reply-to
Content
The ABI of BUILD_MAP_UNPACK_WITH_CALL is changed. oparg=514 meant merging 2 dicts, but with the patch it will mean merging 514 dicts.

The INCREF/DECREF calls on function objects surrounding calls are not needed, because the refcount was increased when the function pushed on the stack. They were needed if use PyMethod optimization, since PyMethod_GET_FUNCTION() returns borrowed link.

Seems you have missed my comments on compile.c.

Added more comments on Rietveld.

What about CALL_FUNCTION_EX benchmarking? Did the optimization help?
History
Date User Action Args
2016-07-01 21:11:46serhiy.storchakasetrecipients: + serhiy.storchaka, haypo, Mark.Shannon, Demur Rumed
2016-07-01 21:11:46serhiy.storchakasetmessageid: <1467407506.89.0.000861799593255.issue27213@psf.upfronthosting.co.za>
2016-07-01 21:11:46serhiy.storchakalinkissue27213 messages
2016-07-01 21:11:46serhiy.storchakacreate