Author yselivanov
Recipients gvanrossum, haypo, j1m, yselivanov
Date 2016-06-29.15:20:31
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <1467213632.05.0.677615336646.issue27392@psf.upfronthosting.co.za>
In-reply-to
Content
> Yury, I'm curious what you think the socket argument to create_connection is about.

:)  The current intended purpose of create_connection is to create a client connection.  You're proposing to add a new argument -- server_side -- which I think will confuse the users of create_connection.

What I'm saying is that we may consider creating a low-level loop.wrap_socket, which would be generic and suitable to be used for both client and server connections.  We could even refactor create_connection to use wrap_socket when 'sock' argument is passed to it.

We already have something similar, although it's a private API -- _make_socket_transport.


> BTW, a problem with this proposal that I realized after submitting it is that it changes an API that has multiple implementations, including implementations outside of the Python codebase.  Arguably, this would require a PEP, at which point the change is no-longer trivial. :)

No need for a PEP; Guido's approval is enough usually.
History
Date User Action Args
2016-06-29 15:20:32yselivanovsetrecipients: + yselivanov, gvanrossum, haypo, j1m
2016-06-29 15:20:32yselivanovsetmessageid: <1467213632.05.0.677615336646.issue27392@psf.upfronthosting.co.za>
2016-06-29 15:20:32yselivanovlinkissue27392 messages
2016-06-29 15:20:31yselivanovcreate