Author josh.r
Recipients docs@python, gmathews, josh.r, rhettinger
Date 2016-06-28.14:42:50
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <1467124970.63.0.136197748511.issue27385@psf.upfronthosting.co.za>
In-reply-to
Content
While you're fixing, the docstring should say "groupby(iterable, key=None)", not "groupby(iterable[, keyfunc])"; the functions accepts the key function by name, and the name is key, not keyfunc. And it can be passed explicitly as None (equivalent to not passing it at all), so the [, keyfunc] approach that indicates it's positional only and can't be explicitly passed as a default is wrong. Gets a little confusing because it also returns a "key", but the argument is definitely named "key", so we can't go calling it "keyfunc".

Mind you, seems like this could also be fixed by just Clinic-ifying it.
History
Date User Action Args
2016-06-28 14:42:50josh.rsetrecipients: + josh.r, rhettinger, docs@python, gmathews
2016-06-28 14:42:50josh.rsetmessageid: <1467124970.63.0.136197748511.issue27385@psf.upfronthosting.co.za>
2016-06-28 14:42:50josh.rlinkissue27385 messages
2016-06-28 14:42:50josh.rcreate