Author exhuma
Recipients James Schneider, JamesGuthrie, SilentGhost, berker.peksag, eric.smith, exhuma, ncoghlan, pitrou, pmoody, r.david.murray
Date 2016-06-25.13:46:48
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <>
I don't quite see how the operator module could help. I don't have much experience with it though, so I might be missing something...

I don't see how I can relate one check to the other. The example I gave in the patch review was the following:

With the existing implementation:

'' subnet of '' -> False
'' supernet of '' -> False

With the proposal to simply return "not subnet_of(...)" it would become:

'' subnet of '' -> False
'' supernet of '' -> True

which would be wrong.

I have now added the new test-cases for the TypeError and removed the code-duplication by introducing a new "private" function. Let me know what you think.

I am running all test cases again and I'll uploaded it once they finished.
Date User Action Args
2016-06-25 13:46:49exhumasetrecipients: + exhuma, ncoghlan, pitrou, eric.smith, pmoody, r.david.murray, SilentGhost, berker.peksag, JamesGuthrie, James Schneider
2016-06-25 13:46:49exhumasetmessageid: <>
2016-06-25 13:46:49exhumalinkissue20825 messages
2016-06-25 13:46:49exhumacreate