➜

This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

Author berker.peksag
Recipients James Schneider, JamesGuthrie, SilentGhost, berker.peksag, eric.smith, exhuma, ncoghlan, pitrou, pmoody, r.david.murray
Date 2016-06-25.11:46:51
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <1466855211.54.0.441640395496.issue20825@psf.upfronthosting.co.za>
In-reply-to
Content 
Thanks for the updated patch. Some comments from a quick review:

* We need tests for the TypeError branches in both methods

* +                            'of type %s' % type(other)

  type(other) -> type(other).__name__

* You can drop the XXX part in

  +XXX Instances of

* Perhaps code duplication mentioned by SilentGhost can be eliminated by using the operator module
History
Date User Action Args
2016-06-25 11:46:51berker.peksagsetrecipients: + berker.peksag, ncoghlan, pitrou, eric.smith, pmoody, r.david.murray, SilentGhost, exhuma, JamesGuthrie, James Schneider
2016-06-25 11:46:51berker.peksagsetmessageid: <1466855211.54.0.441640395496.issue20825@psf.upfronthosting.co.za>
2016-06-25 11:46:51berker.peksaglinkissue20825 messages
2016-06-25 11:46:51berker.peksagcreate