Message269232
Thanks for the updated patch. Some comments from a quick review:
* We need tests for the TypeError branches in both methods
* + 'of type %s' % type(other)
type(other) -> type(other).__name__
* You can drop the XXX part in
+XXX Instances of
* Perhaps code duplication mentioned by SilentGhost can be eliminated by using the operator module |
|
Date |
User |
Action |
Args |
2016-06-25 11:46:51 | berker.peksag | set | recipients:
+ berker.peksag, ncoghlan, pitrou, eric.smith, pmoody, r.david.murray, SilentGhost, exhuma, JamesGuthrie, James Schneider |
2016-06-25 11:46:51 | berker.peksag | set | messageid: <1466855211.54.0.441640395496.issue20825@psf.upfronthosting.co.za> |
2016-06-25 11:46:51 | berker.peksag | link | issue20825 messages |
2016-06-25 11:46:51 | berker.peksag | create | |
|