Author martin.panter
Recipients Rotkraut, demian.brecht, harobed, martin.panter, orsenthil, petri.lehtinen, piotr.dobrogost, pitrou, whitemice
Date 2016-06-17.09:53:04
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <1466157185.24.0.394289163638.issue12319@psf.upfronthosting.co.za>
In-reply-to
Content
FYI instead of changing the helper into a static method, I think you could have just called http.client._get_content_length().

I don’t understand why we need the new encode_chunked=True flag. Can’t urllib.request leave the Transfer-Encoding field up to http.client? Yes it does set Content-Length in the Request object, but it does not set Accept-Encoding nor Connection. Also, it looks like you can still get chunked encoding if you set encode_chunked=False, which is confusing.

I left some review comments, and I think some of my earlier comments still apply. I still find it confusing the variety of objects accepted, and the different levels that the APIs work on. Hopefully it will become less confusing if we can figure out all the corner cases. I do think unifying the data types accepted by urlopen() and HTTPConnection is good, though I am not sure allowing text in urlopen() is the right direction.
History
Date User Action Args
2016-06-17 09:53:05martin.pantersetrecipients: + martin.panter, orsenthil, pitrou, harobed, petri.lehtinen, piotr.dobrogost, demian.brecht, whitemice, Rotkraut
2016-06-17 09:53:05martin.pantersetmessageid: <1466157185.24.0.394289163638.issue12319@psf.upfronthosting.co.za>
2016-06-17 09:53:05martin.panterlinkissue12319 messages
2016-06-17 09:53:04martin.pantercreate