Author terry.reedy
Recipients Friedrich.Spee.von.Langenfeld, SilentGhost, Yoni Lavi, belopolsky, berker.peksag, docs@python, ezio.melotti, nharold, python-dev, r.david.murray, rhettinger, terry.reedy
Date 2016-06-11.19:27:31
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <1465673251.93.0.816376495144.issue22558@psf.upfronthosting.co.za>
In-reply-to
Content
I committed the excellent patch.  It should appear in the upcoming 3.5 and 3.6 releases, and within a day online.  Thanks to both package author and also to reviewers.  I would like to see more patches like this.

I reverted the deletion of version added in mock examples.  It is a separate page, so the reminder is not inappropriate.

Minor nit: Yoni, you 'forgot' to run "python tools/scripts/patchcheck.py" on a patched  repository.  Not too surprisingly, the editing left trailing whitespace that needed to be removed.  See the devguide for more.

A possible follow-on.  Some of the packages that document contained modules do so on the main page rather than in separate pages.  If the source link is to the package __init__, rather than to the package directory, then it would be appropriate to add links to the module sections.  The particular example I am thinking of is importlib, where we linked to .__init__.  There may be another.  Multiprocessing is not, because we linked to the directory.
History
Date User Action Args
2016-06-11 19:27:31terry.reedysetrecipients: + terry.reedy, rhettinger, belopolsky, ezio.melotti, r.david.murray, SilentGhost, docs@python, python-dev, berker.peksag, Friedrich.Spee.von.Langenfeld, Yoni Lavi, nharold
2016-06-11 19:27:31terry.reedysetmessageid: <1465673251.93.0.816376495144.issue22558@psf.upfronthosting.co.za>
2016-06-11 19:27:31terry.reedylinkissue22558 messages
2016-06-11 19:27:31terry.reedycreate