Author ncoghlan
Recipients brett.cannon, gvanrossum, larry, lukasz.langa, ncoghlan, ned.deily, vstinner, yselivanov
Date 2016-06-06.20:46:04
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <1465245964.53.0.017421771135.issue27243@psf.upfronthosting.co.za>
In-reply-to
Content
Since the old behaviour is only deprecated with Yury's changes, rather than disallowed entirely, I think it makes sense to provide a 3.5.x version that also supports the new behaviour.

In addition to my docs comment above, the other thing I noticed in reviewing the patch is that the proposed tests don't currently check that we *don't* emit a deprecation warning for the newly permitted forward compatible cases that return an asynchronous iterator (rather than an awaitable) directly from __aiter__.

There are definitely some tests that exercise that path, so we could rely on the general principle of "the test suite shouldn't emit deprecation warnings", but we could also add some tests that specifically check that no warning is emitted in that case.
History
Date User Action Args
2016-06-06 20:46:04ncoghlansetrecipients: + ncoghlan, gvanrossum, brett.cannon, vstinner, larry, ned.deily, lukasz.langa, yselivanov
2016-06-06 20:46:04ncoghlansetmessageid: <1465245964.53.0.017421771135.issue27243@psf.upfronthosting.co.za>
2016-06-06 20:46:04ncoghlanlinkissue27243 messages
2016-06-06 20:46:04ncoghlancreate