Message267495
Thank you very much for the detailed review, Nathan. Attached is a new patch that resolves the merge issues, and some of the other issues you mentioned.
Concerning the index reference in marshal.rst , ah, yes, I missed that it only related to a single paragraph. I reverted that change.
Concerning versionadded in unittest.mock-examples.rst, you're right, I saw that this was already available elsewhere and removed it for consistency with other similar intro files. I'll revert if you tell me.
I think I fixed all the smaller issues you mentioned, too. I wasn't sure about the fuzz; I didn't see any issue, so I assume it was automatically resolved by `hg update`.
I don't have any input to give concerning the 'subjective' issues and will be happy to wait for a decision. |
|
Date |
User |
Action |
Args |
2016-06-06 00:41:07 | Yoni Lavi | set | recipients:
+ Yoni Lavi, rhettinger, terry.reedy, belopolsky, ezio.melotti, r.david.murray, SilentGhost, docs@python, berker.peksag, Friedrich.Spee.von.Langenfeld, nharold |
2016-06-06 00:41:07 | Yoni Lavi | set | messageid: <1465173667.34.0.454925411894.issue22558@psf.upfronthosting.co.za> |
2016-06-06 00:41:07 | Yoni Lavi | link | issue22558 messages |
2016-06-06 00:41:07 | Yoni Lavi | create | |
|