➜

This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

Author JelleZijlstra
Recipients JelleZijlstra, eryksun, r.david.murray, rhettinger, shakur shams Mullick, theller, vstinner
Date 2016-06-04.19:29:00
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <1465068540.76.0.635903449551.issue21130@psf.upfronthosting.co.za>
In-reply-to
Content 
I think the patch needs more tests, including:
- Comparing a partial against some other objects
- Comparing two partials with a different function
- Comparing two partials with different args

You also need to check each call to PyObject_RichCompareBool for error (it returns -1 on error). I believe the current implementation would silently ignore the error. This behavior should also be tested.

Rietveld is not picking up this diff, maybe because it is a git rather than an hg diff. Generating the diff with hg will make it easier to review.
History
Date User Action Args
2016-06-04 19:29:00JelleZijlstrasetrecipients: + JelleZijlstra, theller, rhettinger, vstinner, r.david.murray, eryksun, shakur shams Mullick
2016-06-04 19:29:00JelleZijlstrasetmessageid: <1465068540.76.0.635903449551.issue21130@psf.upfronthosting.co.za>
2016-06-04 19:29:00JelleZijlstralinkissue21130 messages
2016-06-04 19:29:00JelleZijlstracreate