Message267124
Oh, sorry, I was absentminded. In general the patch LGTM. But I think that using list subclass for tests is not a good idea. If we make a typo in CustomSequence method name (__contain__, inedx, coumt), the test is still passed. It would be better to use a class that doesn't have any sequence-related methods besides explicitly defined. |
|
Date |
User |
Action |
Args |
2016-06-03 18:09:34 | serhiy.storchaka | set | recipients:
+ serhiy.storchaka, rhettinger, stutzbach, python-dev, josh.r, xiang.zhang |
2016-06-03 18:09:34 | serhiy.storchaka | set | messageid: <1464977374.34.0.616355563873.issue26915@psf.upfronthosting.co.za> |
2016-06-03 18:09:34 | serhiy.storchaka | link | issue26915 messages |
2016-06-03 18:09:34 | serhiy.storchaka | create | |
|