Author serhiy.storchaka
Recipients josh.r, python-dev, rhettinger, serhiy.storchaka, stutzbach, xiang.zhang
Date 2016-06-03.18:09:34
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <1464977374.34.0.616355563873.issue26915@psf.upfronthosting.co.za>
In-reply-to
Content
Oh, sorry, I was absentminded. In general the patch LGTM. But I think that using list subclass for tests is not a good idea. If we make a typo in CustomSequence method name (__contain__, inedx, coumt), the test is still passed. It would be better to use a class that doesn't have any sequence-related methods besides explicitly defined.
History
Date User Action Args
2016-06-03 18:09:34serhiy.storchakasetrecipients: + serhiy.storchaka, rhettinger, stutzbach, python-dev, josh.r, xiang.zhang
2016-06-03 18:09:34serhiy.storchakasetmessageid: <1464977374.34.0.616355563873.issue26915@psf.upfronthosting.co.za>
2016-06-03 18:09:34serhiy.storchakalinkissue26915 messages
2016-06-03 18:09:34serhiy.storchakacreate