This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

Author Oren Milman
Recipients Oren Milman, rhettinger, vstinner, yselivanov
Date 2016-06-03.14:44:40
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <>
After giving it some more thought, I feel somewhat uncertain about that check for a failure after using _PyLong_Negate.

At first I noticed that after every call to _PyLong_Negate there is such a check. But then I realized that in my patch, and also in long_mul (in the default branch of CPython), the check is unnecessary, as z is just returned after the call to _PyLong_Negate.

Is adding such a check anyway (e.g. in long_mul) a convention? Or should such checks be removed?
Date User Action Args
2016-06-03 14:44:41Oren Milmansetrecipients: + Oren Milman, rhettinger, vstinner, yselivanov
2016-06-03 14:44:40Oren Milmansetmessageid: <>
2016-06-03 14:44:40Oren Milmanlinkissue27145 messages
2016-06-03 14:44:40Oren Milmancreate