Message267103
After giving it some more thought, I feel somewhat uncertain about that check for a failure after using _PyLong_Negate.
At first I noticed that after every call to _PyLong_Negate there is such a check. But then I realized that in my patch, and also in long_mul (in the default branch of CPython), the check is unnecessary, as z is just returned after the call to _PyLong_Negate.
Is adding such a check anyway (e.g. in long_mul) a convention? Or should such checks be removed? |
|
Date |
User |
Action |
Args |
2016-06-03 14:44:41 | Oren Milman | set | recipients:
+ Oren Milman, rhettinger, vstinner, yselivanov |
2016-06-03 14:44:40 | Oren Milman | set | messageid: <1464965080.99.0.598828905697.issue27145@psf.upfronthosting.co.za> |
2016-06-03 14:44:40 | Oren Milman | link | issue27145 messages |
2016-06-03 14:44:40 | Oren Milman | create | |
|