Message266798
Here's some quick review comments:
* xmlrpc_register_decorator_py33.patch doesn't apply cleanly anymore.
* - serv.register_function(my_function)
+ serv.register_function(_my_function, name='my_function')
We should keep ``serv.register_function(my_function)`` as is and add a separate line that uses the new 'name' parameter.
* We can now change set([...]) to {...] in test_introspection1
* + add_result, pow_result, div_result, \
+ myfunc_result, myfunc2_result = multicall()
No need to use the \ character.
* The docstring of Lib/xmlrpc/server.py is already too long. It's better not to update it.
* Please use the existing code style (name = None -> name=None)
* We can make register_function act both as a decorator and as a decorator factory without changing its signature.
* We need to add a test to cover TypeError case.
* Documentation is missing. See Doc/library/xmlrpc.server.rst.
* Please add a note to Doc/whatsnew/3.6.rst. |
|
Date |
User |
Action |
Args |
2016-06-01 04:00:49 | berker.peksag | set | recipients:
+ berker.peksag, brian.curtin, ahojnnes, santoso.wijaya, Claudiu.Popa |
2016-06-01 04:00:49 | berker.peksag | set | messageid: <1464753649.75.0.712971419611.issue7769@psf.upfronthosting.co.za> |
2016-06-01 04:00:49 | berker.peksag | link | issue7769 messages |
2016-06-01 04:00:49 | berker.peksag | create | |
|