Message266726
Berker, I don't mind if people mark their own patches for commit review *when they think it is ready for commit*. (Just as with reviewers, if they start being consistently right, they are ready for commit privs :) However, a non-committer setting a patch to commit review is waving a hand for attention from a core dev, and that should only be done *after* a patch has been *reviewed* and judged ready for final review before commit.
(I broke my own rule the other day and got in trouble, though...I set a patch to commit review to remind myself to review it rather than because I thought it was commit ready already, and it got committed...) |
|
Date |
User |
Action |
Args |
2016-05-31 00:42:10 | r.david.murray | set | recipients:
+ r.david.murray, gvanrossum, rhettinger, steven.daprano, berker.peksag, serhiy.storchaka, eryksun, ppperry, abarry |
2016-05-31 00:42:10 | r.david.murray | set | messageid: <1464655330.09.0.252367720564.issue27157@psf.upfronthosting.co.za> |
2016-05-31 00:42:10 | r.david.murray | link | issue27157 messages |
2016-05-31 00:42:08 | r.david.murray | create | |
|