This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

Author martin.panter
Recipients Unit03, martin.panter, serhiy.storchaka
Date 2016-05-29.00:06:10
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <1464480371.21.0.0657202206242.issue27112@psf.upfronthosting.co.za>
In-reply-to
Content
Changing the names to tokenize.<name> does solve the problem of the tokenize module versus the tokenize() fuction, so I can accept this way since you prefer it.

So I think that just leaves what to do with the actual test case. I don’t think it matters too much, but I would lean toward ensuring the test fails if someone adds a new implementation detail without an underscore prefix. It is also good to be explicit that the ISTERMINAL() etc functions are special cases.

On the other hand, neither the original patch nor Jacek’s proposal for “expected = token.__all__ + ...” would pick up the fact that the tok_name dictionary is another special case copied from the “token” module. (See also Issue 25324.)
History
Date User Action Args
2016-05-29 00:06:11martin.pantersetrecipients: + martin.panter, serhiy.storchaka, Unit03
2016-05-29 00:06:11martin.pantersetmessageid: <1464480371.21.0.0657202206242.issue27112@psf.upfronthosting.co.za>
2016-05-29 00:06:11martin.panterlinkissue27112 messages
2016-05-29 00:06:10martin.pantercreate