Author hakril
Recipients hakril, markgrandi, steve.dower, tim.golden, zach.ware
Date 2016-05-23.11:15:45
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <1464002145.78.0.890383559449.issue23026@psf.upfronthosting.co.za>
In-reply-to
Content
I also stumbled on this issue when playing with the winreg module.
I will try to make the discussion go forward by submitting a new patch.
I added a test and tried everything (test included on 3.5) on my own computer (windows 8.1 64b)
There are two points that might be 'sensitive' and I would like to have someone's opinion:
    * I am using `DWORD64` as an unsigned 64bit value as `QWORD` is not defined in <windows.h>
    * I changed one line of the previous implementation for REG_DWORD:
        * `PyLong_FromUnsignedLong(*(int *)retDataBuf);` became `PyLong_FromUnsignedLong(*(DWORD *)retDataBuf);`
        * I don't think it is a problem, but better ask than break something
History
Date User Action Args
2016-05-23 11:15:45hakrilsetrecipients: + hakril, tim.golden, zach.ware, markgrandi, steve.dower
2016-05-23 11:15:45hakrilsetmessageid: <1464002145.78.0.890383559449.issue23026@psf.upfronthosting.co.za>
2016-05-23 11:15:45hakrillinkissue23026 messages
2016-05-23 11:15:45hakrilcreate