Author Michał Bednarski
Recipients Michał Bednarski, vstinner
Date 2016-05-19.14:01:33
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <1463666494.01.0.269153716342.issue27057@psf.upfronthosting.co.za>
In-reply-to
Content
> Hum, I'm surprised that SELinux blocks such safe function. Maybe the SELinux policy should be completed to allow it?
The ioctl is blocked for given file type regardless of request argument. As I'm running Python on non-rooted Android updating policy is not really an option.

> But do you expect ioctl() to always fail with EACCESS? Or only fail sometimes, or only on some file descriptors? Your patch remembers that ioctl() fails once and never retries.
It will always fail for given file type (such as sockets), while it will work for others (such as regular files). I think that remembering that ioctl doesn't work may be okay, though I may be wrong. Either way if we are wrong whenever ioctl works we'll do one extra syscall.

> About your patch: please add a comment explaining why you fallback with a reference to this issue ("Issue #27057").
Attached
History
Date User Action Args
2016-05-19 14:01:34Michał Bednarskisetrecipients: + Michał Bednarski, vstinner
2016-05-19 14:01:34Michał Bednarskisetmessageid: <1463666494.01.0.269153716342.issue27057@psf.upfronthosting.co.za>
2016-05-19 14:01:33Michał Bednarskilinkissue27057 messages
2016-05-19 14:01:33Michał Bednarskicreate