Message 265854 - Python tracker

➜

This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

Author	vstinner
Recipients	Michał Bednarski, vstinner
Date	2016-05-19.12:54:27
SpamBayes Score	-1.0
Marked as misclassified	Yes
Message-id	<1463662468.55.0.286852576207.issue27057@psf.upfronthosting.co.za>
In-reply-to

Content
Hum, I'm surprised that SELinux blocks such safe function. Maybe the SELinux policy should be completed to allow it? Detect when ioctl() fails with EACCESS and fallback to fnctl() sounds like a good option. But do you expect ioctl() to always fail with EACCESS? Or only fail sometimes, or only on some file descriptors? Your patch remembers that ioctl() fails once and never retries. About your patch: please add a comment explaining why you fallback with a reference to this issue ("Issue #27057").

Hum, I'm surprised that SELinux blocks such safe function. Maybe the SELinux policy should be completed to allow it?

Detect when ioctl() fails with EACCESS and fallback to fnctl() sounds like a good option. But do you expect ioctl() to always fail with EACCESS? Or only fail sometimes, or only on some file descriptors? Your patch remembers that ioctl() fails once and never retries.

About your patch: please add a comment explaining why you fallback with a reference to this issue ("Issue #27057").

History
Date	User	Action	Args
2016-05-19 12:54:28	vstinner	set	recipients: + vstinner, Michał Bednarski
2016-05-19 12:54:28	vstinner	set	messageid: <1463662468.55.0.286852576207.issue27057@psf.upfronthosting.co.za>
2016-05-19 12:54:28	vstinner	link	issue27057 messages
2016-05-19 12:54:27	vstinner	create