Author martin.panter
Recipients Dhiraj_Mishra, martin.panter, mbussonn, python-dev, serhiy.storchaka, takluyver
Date 2016-05-14.23:29:05
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <1463268545.68.0.516814608182.issue26039@psf.upfronthosting.co.za>
In-reply-to
Content
The bonus patch looks okay, although I wonder if the directory slash (/) information should be in the RST rather than doc string. Usually the RST has all the details, and doc strings are just summaries.

Regarding exceptions, I can sympathise with both sides of the argument and don’t have a strong opinion (why does the exception type matter for programmer errors anyway?). But I think it might be better to be locally consistent within the zipfile module, and the module is already heavily documented with RuntimeError for similar programmer errors.
History
Date User Action Args
2016-05-14 23:29:05martin.pantersetrecipients: + martin.panter, python-dev, takluyver, serhiy.storchaka, mbussonn, Dhiraj_Mishra
2016-05-14 23:29:05martin.pantersetmessageid: <1463268545.68.0.516814608182.issue26039@psf.upfronthosting.co.za>
2016-05-14 23:29:05martin.panterlinkissue26039 messages
2016-05-14 23:29:05martin.pantercreate